From c7bcd80b1748e1186ec7f551e6662cdd401adedc Mon Sep 17 00:00:00 2001
From: Spitap <dev@asdrip.fr>
Date: Sat, 25 Feb 2023 10:44:30 +0100
Subject: [PATCH] refactor tests, updated lib to cover write permission issue

Please work codecov
---
 modoboa/pdfcredentials/lib.py                            | 7 ++++++-
 modoboa/pdfcredentials/tests/__init__.py                 | 1 +
 modoboa/pdfcredentials/{tests.py => tests/test_views.py} | 0
 3 files changed, 7 insertions(+), 1 deletion(-)
 create mode 100644 modoboa/pdfcredentials/tests/__init__.py
 rename modoboa/pdfcredentials/{tests.py => tests/test_views.py} (100%)

diff --git a/modoboa/pdfcredentials/lib.py b/modoboa/pdfcredentials/lib.py
index a7bd85a4d..6817f0479 100644
--- a/modoboa/pdfcredentials/lib.py
+++ b/modoboa/pdfcredentials/lib.py
@@ -18,8 +18,13 @@ from modoboa.parameters import tools as param_tools
 def init_storage_dir():
     """Create the directory whare documents will be stored."""
     storage_dir = param_tools.get_global_parameter("storage_dir")
-    if os.path.exists(storage_dir):
+    if os.path.exists(storage_dir) and os.access(storage_dir, os.W_OK):
         return
+    elif not os.access(storage_dir, os.W_OK) and os.path.exists(storage_dir):
+        raise InternalError(
+            _("Can't write to selected directory to store PDF "
+                "documents")
+            )
     try:
         os.mkdir(storage_dir)
     except (OSError, IOError) as inst:
diff --git a/modoboa/pdfcredentials/tests/__init__.py b/modoboa/pdfcredentials/tests/__init__.py
new file mode 100644
index 000000000..8b1378917
--- /dev/null
+++ b/modoboa/pdfcredentials/tests/__init__.py
@@ -0,0 +1 @@
+
diff --git a/modoboa/pdfcredentials/tests.py b/modoboa/pdfcredentials/tests/test_views.py
similarity index 100%
rename from modoboa/pdfcredentials/tests.py
rename to modoboa/pdfcredentials/tests/test_views.py