From c4324d08c625f67a15016e48e12109e8d8fa1b58 Mon Sep 17 00:00:00 2001
From: Antoine Nguyen <tonio@ngyn.org>
Date: Wed, 20 Mar 2024 11:43:45 +0100
Subject: [PATCH] Added missing permission view_domainalias to DomainAdmins
 group

---
 .../migrations/0023_auto_20240320_1037.py     | 25 +++++++++++++++++++
 modoboa/core/constants.py                     |  1 +
 .../management/commands/load_initial_data.py  |  3 ++-
 3 files changed, 28 insertions(+), 1 deletion(-)
 create mode 100644 modoboa/admin/migrations/0023_auto_20240320_1037.py

diff --git a/modoboa/admin/migrations/0023_auto_20240320_1037.py b/modoboa/admin/migrations/0023_auto_20240320_1037.py
new file mode 100644
index 000000000..776e10de5
--- /dev/null
+++ b/modoboa/admin/migrations/0023_auto_20240320_1037.py
@@ -0,0 +1,25 @@
+# Generated by Django 4.2.11 on 2024-03-20 10:37
+
+from django.db import migrations
+
+
+def set_missing_permission(apps, schema_editor):
+    Permission = apps.get_model("auth", "Permission")
+    Group = apps.get_model("auth", "Group")
+    group = Group.objects.filter(name="DomainAdmins").first()
+    if not group:
+        # Fresh install, nothing to do
+        return
+    perm = Permission.objects.get(codename="view_domainalias")
+    group.permissions.add(perm)
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("admin", "0022_alter_alarm_domain"),
+    ]
+
+    operations = [
+        migrations.RunPython(set_missing_permission, migrations.RunPython.noop),
+    ]
diff --git a/modoboa/core/constants.py b/modoboa/core/constants.py
index e407a4ed7..612682e07 100644
--- a/modoboa/core/constants.py
+++ b/modoboa/core/constants.py
@@ -78,6 +78,7 @@ PERMISSIONS = {
         ["admin", "senderaddress", "add_senderaddress"],
         ["admin", "senderaddress", "change_senderaddress"],
         ["admin", "senderaddress", "delete_senderaddress"],
+        ["admin", "domainalias", "view_domainalias"],
     ],
     "Resellers": [
         ["core", "user", "add_user"],
diff --git a/modoboa/core/management/commands/load_initial_data.py b/modoboa/core/management/commands/load_initial_data.py
index 3a19086f6..8f22d5806 100644
--- a/modoboa/core/management/commands/load_initial_data.py
+++ b/modoboa/core/management/commands/load_initial_data.py
@@ -1,4 +1,5 @@
-"""A management command to load Modoboa initial data:
+"""
+A management command to load Modoboa initial data.
 
 * Create a default super admin if none exists
 * Create groups and permissions