From 5164ecdfdf70815177d5f4eb57454bd0132a085b Mon Sep 17 00:00:00 2001 From: Antoine Nguyen Date: Wed, 31 Jan 2018 11:42:44 +0100 Subject: [PATCH] fix: do not save the domain if not necessary. it will also avoid the trigger of two post_save signals for the domain, which can lead to unexpected issues. see #1380 --- modoboa/relaydomains/forms.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/modoboa/relaydomains/forms.py b/modoboa/relaydomains/forms.py index ca9316aac..52d9518f8 100644 --- a/modoboa/relaydomains/forms.py +++ b/modoboa/relaydomains/forms.py @@ -37,6 +37,7 @@ class RelayDomainFormGeneral(tr_forms.TransportForm): instance.pattern = domain.name instance.service = "relay" instance.save() - domain.transport = instance - domain.save(update_fields=["transport"]) + if not domain.transport: + domain.transport = instance + domain.save(update_fields=["transport"]) return instance