From 2ff4e01f6dd55e3b02f554f3a2b580001a1162ae Mon Sep 17 00:00:00 2001
From: Antoine Nguyen <tonio@ngyn.org>
Date: Mon, 4 Jul 2011 09:11:23 +0200
Subject: [PATCH] Fixed javascript error occuring on "match-type" selection
 change.

see #139
---
 .../sievefilters/templates/sievefilters/filter.html    | 10 +++++-----
 extensions/sievefilters/views.py                       |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/extensions/sievefilters/templates/sievefilters/filter.html b/extensions/sievefilters/templates/sievefilters/filter.html
index 234583c10..065b1d425 100644
--- a/extensions/sievefilters/templates/sievefilters/filter.html
+++ b/extensions/sievefilters/templates/sievefilters/filter.html
@@ -77,11 +77,11 @@ $(document).addEvent("domready", function() {
       <div class="spacer"></div>
     </div>
     <div class="spacer"></div>
-    {% if hideconds %}<div id="hide" style="display:none">{% endif %}
-    {% for ec in conds_nb %}
-    {% display_condition form ec %}
-    {% endfor %}
-    {% if hideconds %}</div>{% endif %}
+    <div id="hide" style="display:{{ hidestyle }}">
+      {% for ec in conds_nb %}
+      {% display_condition form ec %}
+      {% endfor %}
+    </div>
   </div>
   <h2>{% trans "Actions" %}</h2>
   <div id="actionlist">
diff --git a/extensions/sievefilters/views.py b/extensions/sievefilters/views.py
index b8abcafed..b46533d1b 100644
--- a/extensions/sievefilters/views.py
+++ b/extensions/sievefilters/views.py
@@ -130,8 +130,8 @@ def editfilter(request, setname, fname, tplname="sievefilters/filter.html"):
     form = build_filter_form_from_filter(request, fname, f)
     ctx = build_filter_ctx(ctx, form)
     ctx["oldname"] = fname
-    if form.fields["match_type"].initial == "all":
-        ctx["hideconds"] = True
+    ctx["hidestyle"] = "none" \
+        if form.fields["match_type"].initial == "all" else "block"
     return _render(request, tplname, ctx)
 
 @login_required