diff --git a/modoboa/lib/templatetags/form_tags.py b/modoboa/lib/templatetags/form_tags.py
index a1c98561b..5d4e01a42 100644
--- a/modoboa/lib/templatetags/form_tags.py
+++ b/modoboa/lib/templatetags/form_tags.py
@@ -38,42 +38,19 @@ def configure_field_classes(field):
@register.simple_tag
def render_field(
field, help_display_mode="tooltip", label_width="col-sm-4",
- hidden=False):
+ **options):
"""Render a field."""
from modoboa.core.templatetags.core_tags import visirule
if type(field.field) is SeparatorField:
return "
%s
" % (visirule(field), unicode(field.label))
configure_field_classes(field)
- return render_to_string("common/generic_field.html", dict(
- field=field, help_display_mode=help_display_mode,
- label_width=label_width, hidden=hidden
- ))
-
-
-@register.simple_tag
-def render_field_appended(field, text):
- configure_field_classes(field)
- return render_to_string("common/generic_field.html", dict(
- field=field, help_display_mode="tooltip", appended_text=text
- ))
-
-
-@register.simple_tag
-def render_field_with_activator(field, activator_label=ugettext_lazy("activate")):
- configure_field_classes(field)
- return render_to_string("common/generic_field.html", {
- "field": field, "help_display_mode": "tooltip", "activator": True,
- "activator_label": activator_label, "deactivate_if_empty": True
- })
-
-
-@register.simple_tag
-def render_and_hide_field(field):
- configure_field_classes(field)
- return render_to_string("common/generic_field.html", dict(
- field=field, hidden=True
- ))
+ context = {
+ "field": field, "help_display_mode": help_display_mode,
+ "label_width": label_width, "deactivate_if_empty": True
+ }
+ context.update(options)
+ return render_to_string("common/generic_field.html", context)
@register.simple_tag
diff --git a/modoboa/static/js/dynamic_input.js b/modoboa/static/js/dynamic_input.js
index 08fe2c9bb..509c29c24 100644
--- a/modoboa/static/js/dynamic_input.js
+++ b/modoboa/static/js/dynamic_input.js
@@ -25,7 +25,7 @@
addrmlink: function(input) {
var $rmlink = $('
');
+ + '">
');
$rmlink.click($.proxy(this.removeinput, $rmlink));
return $rmlink;
@@ -102,4 +102,4 @@
emptylabel: ""
};
-})(jQuery);
\ No newline at end of file
+})(jQuery);
diff --git a/modoboa/static/js/global.js b/modoboa/static/js/global.js
index d40dafb55..599498644 100644
--- a/modoboa/static/js/global.js
+++ b/modoboa/static/js/global.js
@@ -86,7 +86,7 @@ function build_alert_box(msg, level) {
}
function build_error_alert(msg) {
- return build_alert_box(msg, 'error');
+ return build_alert_box(msg, 'danger');
}
function build_success_alert(msg) {
@@ -152,12 +152,12 @@ function display_form_errors(formid, data) {
*/
function simple_ajax_form_post(e, options) {
e.preventDefault();
- var $form = (options.formid != undefined) ? $("#" + options.formid) : $("form");
+ var $form = (options.formid !== undefined) ? $("#" + options.formid) : $("form");
var defaults = {reload_on_success: true, reload_mode: 'full', modal: true};
var opts = $.extend({}, defaults, options);
var args = $form.serialize();
- if (options.extradata != undefined) {
+ if (options.extradata !== undefined) {
args += "&" + options.extradata;
}
$.ajax({
@@ -210,12 +210,12 @@ function gethref(obj) {
var re = new RegExp("^(https?):");
var scheme = re.exec(url);
- if (scheme != null) {
+ if (scheme !== null) {
var baseurl = scheme[0] + "://" + location.host + location.pathname;
return url.replace(baseurl, "");
}
return url;
-};
+}
/*
* Extract the current URL parameters into a dictionnary.
diff --git a/modoboa/templates/common/generic_modal_form.html b/modoboa/templates/common/generic_modal_form.html
index 8f3294cf6..fec8c8fcf 100644
--- a/modoboa/templates/common/generic_modal_form.html
+++ b/modoboa/templates/common/generic_modal_form.html
@@ -3,7 +3,7 @@
{% load form_tags %}
{% block modalbody %}
- {% if error %}
{{ error }}
{% endif %}
+ {% if error %}
{{ error }}
{% endif %}