clean up contract review findings

api/src/foreign.rs

@@ -462,7 +462,7 @@ where
 
 	// Below is a foreign wrapper around owner calls to 'new' and 'sign' which are only executed
 	// if this is a receiving contract. This preserves the ability to receive on a foreign interface.
-	/// TODO
+	/// Start a receiving contract through the foreign API.
 	pub fn contract_new(
 		&self,
 		keychain_mask: Option<&SecretKey>,
@@ -473,7 +473,7 @@ where
 		foreign::contract_new(w, keychain_mask, args)
 	}
 
-	/// TODO
+	/// Sign the receiving side of a contract through the foreign API.
 	pub fn contract_sign(
 		&self,
 		keychain_mask: Option<&SecretKey>,
@@ -485,7 +485,7 @@ where
 		foreign::contract_sign(w, keychain_mask, args, slate)
 	}
 
-	/// TODO
+	/// Verify an invoice payment proof against the chain.
 	pub fn verify_payment_proof_invoice(
 		&self,
 		recipient_address: &DalekPublicKey,

api/src/foreign_rpc.rs

@@ -386,14 +386,6 @@ pub fn run_doctest_foreign(
 	)
 	.unwrap();
 
-	let _ = fs::create_dir_all(test_dir);
-	let config = initial_setup_wallet(
-		&ChainTypes::AutomatedTesting,
-		Some(PathBuf::from(test_dir)),
-		false,
-	)
-	.unwrap();
-
 	let mut wallet_proxy: WalletProxy<
 		DefaultLCProvider<LocalWalletClient, ExtKeychain>,
 		LocalWalletClient,

api/src/owner_rpc.rs

@@ -2666,14 +2666,6 @@ pub fn run_doctest_owner(
 	)
 	.unwrap();
 
-	let _ = fs::create_dir_all(test_dir);
-	let config = initial_setup_wallet(
-		&ChainTypes::AutomatedTesting,
-		Some(PathBuf::from(test_dir)),
-		false,
-	)
-	.unwrap();
-
 	let mut wallet_proxy: WalletProxy<
 		DefaultLCProvider<LocalWalletClient, ExtKeychain>,
 		LocalWalletClient,