github-jwinterm/grin-wallet
1
0
Fork 0
mirror of https://github.com/jwinterm/grin-wallet.git synced 2026-10-17 07:11:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

Contracts: validate num_participants before fee math

Browse Source 
num_participants is divided into the kernel cost, so 0 caused a divide-by-zero
(inf -> garbage fee). Validate it in context::create, the common setup path for
every party: the initiator's value comes from args and the signer's from the
slate, so this also rejects a tampered slate. Only 1 (self-spend) and 2
(standard) are supported today; lift the upper bound when multi-party contracts
are implemented.

Addresses PR #754 review (wallet_args.rs:1039).
This commit is contained in:
jwinterm
2026-06-07 16:33:59 -04:00
parent d4d5f97bd8
commit 5cc1683a1b
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libwallet/src/contract/context.rs
+11
View File
@@ -81,6 +81,17 @@ where
K: Keychain + 'a,
{
debug!("Creating a new contract context");
// Validate num_participants before any fee math (kernel cost is divided by it, so 0
// would be a divide-by-zero). This is the common setup path for every party (the
// signer's value comes from the slate), so it also guards against a tampered slate.
// Only 1 (self-spend) and 2 (standard) are implemented today; lift this when
// multi-party contracts are supported.
if setup_args.num_participants < 1 || setup_args.num_participants > 2 {
return Err(Error::GenericError(format!(
"Unsupported num_participants: {} (expected 1 or 2)",
setup_args.num_participants
)));
}
// sender should always refresh outputs
updater::refresh_outputs(w, keychain_mask, parent_key_id, false)?;