From 93ed1bd9eedc5eeab4381dd91c8ba96a2c63070d Mon Sep 17 00:00:00 2001 From: jwinterm Date: Wed, 20 May 2026 19:19:52 -0400 Subject: [PATCH] Windows CI: source MinGW runtime DLLs from Flutter's bundled mingit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Flutter ships its own copy of Git ("mingit") at C:\flutter\bin\mingit\, which includes the MinGW runtime DLLs (libssp-0.dll, libwinpthread-1.dll). This is guaranteed present on every runner since Flutter is a hard prerequisite. Prefer it over choco's mingw package or the system Git install — both of which proved fragile (choco's mingw install didn't land at the documented path, and the system Git's mingw64\bin had been overwritten by some other tool's .NET assemblies). --- .github/workflows/build-windows.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 465984a7..9f3f1169 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -182,9 +182,10 @@ jobs: # MinGW-w64 distribution, which ships the same x86_64-w64-mingw32 # ABI used to build the wallet libs. RUNTIME_PATHS=( + "/c/flutter/bin/mingit/mingw64/bin" # Flutter's bundled mingit — guaranteed present since Flutter is "$SRC" # monero_c bundle "/c/ProgramData/chocolatey/lib/mingw/tools/install/mingw64/bin" # choco install -y mingw - "/c/Program Files/Git/mingw64/bin" # Git for Windows + "/c/Program Files/Git/mingw64/bin" # Git for Windows (may be overwritten by other tools) "/mingw64/bin" # MSYS2 fallback ) for runtime in libssp-0.dll libwinpthread-1.dll; do -- 2.50.1 (Apple Git-155)