From 65aafa50d6fa569d8a86a0764ebd5e257f7bb221 Mon Sep 17 00:00:00 2001 From: jwinterm Date: Wed, 20 May 2026 19:03:41 -0400 Subject: [PATCH] Windows CI: pull MinGW runtime DLLs from choco's mingw install Git for Windows ships a stripped-down MinGW that doesn't include libssp-0.dll. Add C:\ProgramData\chocolatey\lib\mingw\tools\install\ mingw64\bin (the canonical layout from `choco install -y mingw`) as the primary search location for libssp-0 + libwinpthread-1. Also dump the contents of each candidate path on failure so we can see what's there. --- .github/workflows/build-windows.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index d38be558..465984a7 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -182,9 +182,10 @@ jobs: # MinGW-w64 distribution, which ships the same x86_64-w64-mingw32 # ABI used to build the wallet libs. RUNTIME_PATHS=( - "$SRC" # monero_c bundle (preferred if present) - "/c/Program Files/Git/mingw64/bin" # Git for Windows / Git Bash - "/mingw64/bin" # MSYS2 mingw64 fallback + "$SRC" # monero_c bundle + "/c/ProgramData/chocolatey/lib/mingw/tools/install/mingw64/bin" # choco install -y mingw + "/c/Program Files/Git/mingw64/bin" # Git for Windows + "/mingw64/bin" # MSYS2 fallback ) for runtime in libssp-0.dll libwinpthread-1.dll; do src="" @@ -197,6 +198,10 @@ jobs: if [[ -z "$src" ]]; then echo "FATAL: $runtime not found in any of:" printf ' %s\n' "${RUNTIME_PATHS[@]}" + for d in "${RUNTIME_PATHS[@]}"; do + echo "--- contents of $d (if exists) ---" + ls "$d" 2>/dev/null | head -20 || echo "(missing)" + done exit 1 fi cp -v "$src" "$MONERO_DST/x86_64-w64-mingw32_${runtime}" -- 2.50.1 (Apple Git-155)