Builds/hash-wallet
1
0
Fork 0
forked from github-such-software/hash-wallet
Code Pull Requests Actions Activity

Fix dangling 'if (!isMoneroOnly) ...[' in support_view_model.dart #8

Merged
such-gitea merged 1 commits from github-such-software/hash-wallet:dev into dev 2026-05-16 12:26:16 -04:00
Conversation 0 Commits 1 Files Changed 1 -1
such-gitea commented 2026-05-16 12:26:11 -04:00
Owner
Copy Link

Python regex strip from 6ec755ec2 removed the MoonPay + Robinhood
LinkListItem entries that lived inside an 'if (!isMoneroOnly) ...[ ]'
conditional list-spread, but left the opening '...[' dangling at
line 66 with no matching close bracket. mobx_codegen and hive_generator
both threw 'Expected to find ]' at line 67.

Remove the dead conditional. Build moves past secrets-generation +
mobx-codegen + hive-generator now.

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed
Python regex strip from 6ec755ec2 removed the MoonPay + Robinhood LinkListItem entries that lived inside an 'if (!isMoneroOnly) ...[ ]' conditional list-spread, but left the opening '...[' dangling at line 66 with no matching close bracket. mobx_codegen and hive_generator both threw 'Expected to find ]' at line 67. Remove the dead conditional. Build moves past secrets-generation + mobx-codegen + hive-generator now. Issue Number (if Applicable): Fixes # # Description Please include a summary of the changes and which issue is fixed / feature is added. # Pull Request - Checklist - [ ] Initial Manual Tests Passed - [ ] Double check modified code and verify it with the feature/task requirements - [ ] Format code - [ ] Look for code duplication - [ ] Clear naming for variables and methods - [ ] Manual tests in accessibility mode (TalkBack on Android) passed
such-gitea added 1 commit 2026-05-16 12:26:11 -04:00
Fix dangling 'if (!isMoneroOnly) ...[' in support_view_model.dart
Some checks failed
Hash Wallet Linux build / build (pull_request) Has been cancelled
Details
d03fd909ef 
Python regex strip from 6ec755ec2 removed the MoonPay + Robinhood
LinkListItem entries that lived inside an 'if (!isMoneroOnly) ...[ ]'
conditional list-spread, but left the opening '...['  dangling at
line 66 with no matching close bracket. mobx_codegen and hive_generator
both threw 'Expected to find ]' at line 67.

Remove the dead conditional. Build moves past secrets-generation +
mobx-codegen + hive-generator now.
such-gitea merged commit fa149ddfe8 into dev 2026-05-16 12:26:16 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
such-gitea
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Builds/hash-wallet#8
Delete Branch "github-such-software/hash-wallet:dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?